Skip to content

ARROW-825: [Python] Rename pyarrow.from_pylist to pyarrow.array, test on tuples#552

Closed
wesm wants to merge 3 commits intoapache:masterfrom
wesm:ARROW-825
Closed

ARROW-825: [Python] Rename pyarrow.from_pylist to pyarrow.array, test on tuples#552
wesm wants to merge 3 commits intoapache:masterfrom
wesm:ARROW-825

Conversation

@wesm
Copy link
Copy Markdown
Member

@wesm wesm commented Apr 16, 2017

The idea is to make this function more semantically analogous to numpy.array -- convert to native data structure with optional explicit type.

wesm added 3 commits April 16, 2017 12:12
Change-Id: I8771d38567fd361d226927b032bcf7a4d9f976f2
Change-Id: I4d72b4e53131c1c514ac2a908a1a437a807908a3
Change-Id: I562370cf2fd0cc5dc8a4dc0986e8ce999aba3b16
@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 16, 2017

Rebased

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this method has a much more general name, I would expect it to also be able to take NumPy Arrays and convert them in a fast path.

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 16, 2017

Agreed. Let's open a new JIRA for this? The existing NumPy import assumes the pandas memory model / null encoding, but here I think we would want to import as-is without any null assumptions

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 16, 2017

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 17, 2017

+1

@asfgit asfgit closed this in 84d725b Apr 17, 2017
@wesm wesm deleted the ARROW-825 branch April 17, 2017 21:48
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
… on tuples

The idea is to make this function more semantically analogous to `numpy.array` -- convert to native data structure with optional explicit type.

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes apache#552 from wesm/ARROW-825 and squashes the following commits:

5d69c70 [Wes McKinney] Update test_jemalloc after ARROW-830
c25fdee [Wes McKinney] Update docstring
3a284b7 [Wes McKinney] Rename pyarrow.from_pylist to pyarrow.array, test on tuples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants